Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clang-format: add GIT_DESCRIBE_MATCH #168

Closed
wants to merge 1 commit into from
Closed

feat: clang-format: add GIT_DESCRIBE_MATCH #168

wants to merge 1 commit into from

Conversation

silverjam
Copy link
Contributor

No description provided.

@silverjam silverjam requested a review from a team as a code owner September 20, 2023 20:21
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jungleraptor
jungleraptor reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense in this context?

The idea here is that the last tag is a heuristic for "get me all the files that have changed in this diff"

I don't think it hurts much to match on a pattern - there'll just be longer list of files that the formatter will be run against - but I also don't see how it's useful.

@silverjam
Copy link
Contributor Author

Does this make sense in this context?

The idea here is that the last tag is a heuristic for "get me all the files that have changed in this diff"

I don't think it hurts much to match on a pattern - there'll just be longer list of files that the formatter will be run against - but I also don't see how it's useful.

Nope, doesn't make sense given that, thanks.

@silverjam silverjam closed this Sep 22, 2023
@silverjam silverjam deleted the silverjam/git-describe-match branch September 22, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungleraptor jungleraptor jungleraptor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverjam @jungleraptor